0000087: SQL query don't execute right after open

(0000143)
subzero (administrator)
2008-02-02 10:31

where exactly do you have text cusror in the editor?

What is the SQL statement?

(0000144)
yura_dev (reporter)
2008-02-02 11:30
edited on: 2008-02-02 11:37

> where exactly do you have text cusror in the editor?
SQL editor not focused.
>What is the SQL statement?
Not important.

When text cursor in editor sql statement execute normally, but if sql editor not focused, SQL query not execute. It's right?

(0000145)
subzero (administrator)
2008-02-02 14:14

ok, thanks. It can be fixed easily. I'll do it later this week.

(0000150)
subzero (administrator)
2008-02-04 14:33

can you test it with current revision (386 or later), please?

I could not reproduce sql editor without the focus, but I did some changes to place the cursor in the widget by default.

(0000156)
yura_dev (reporter)
2008-02-04 18:33

In revision 388 bug still exist. What debugger are you use on windows? Maybe i can create patch.

(0000157)
subzero (administrator)
2008-02-04 18:51

I do not use any specialized IDE on windows. Just gvim and mingw compiler. Debugging outputs are done by qDebug().

BTW where is the focus in the sqliteman window just after app started up?

(0000158)
yura_dev (reporter)
2008-02-04 19:36
edited on: 2008-02-04 20:00

>BTW where is the focus in the sqliteman window just after app started up?
In SQL Editor

(0000160)
yura_dev (reporter)
2008-02-05 09:57

Maybe you can reproduce bug, if I describe bug more detailed
1. Run sqliteman
2. Open database
3. Click "New" in SQL editor. Click "Yes" in dialog "New" if need.
4. Open SQL query
5. Run SQL.
6. Open SQL query again
7. Run SQL.
Appear message "Undefined SQL query". On step 4-7 you not should give focus SQL editor.
I sure this bug exist because SQL editor lost focus.
In void SqlEditor::action_Run_SQL_triggered() function query() return empty string in this case.

(0000161)
yura_dev (reporter)
2008-02-05 12:10

After debug I found problem in sqleditor.cpp, line 100
if (ui.sqlTextEdit->hasSelectedText())

Maybe hasSelectedText() not should use:
http://doc.trolltech.com/4.3/qtextedit-qt3.html#hasSelectedText [^]

(0000162)
subzero (administrator)
2008-02-05 13:26

ui.sqlTextEdit is inherited from QsciScitnilla:

http://www.riverbankcomputing.com/Docs/QScintilla2/classQsciScintilla.html#4ad54eea41481334d04626732571e01f [^]

anyway, it seems fixed in the current revision. Please try fresh SVN.

(0000165)
yura_dev (reporter)
2008-02-05 14:03

It works.

(0000167)
subzero (administrator)
2008-02-05 14:11

perfect. Thanks for help.

Notes
(0000143) subzero (administrator) 2008-02-02 10:31	where exactly do you have text cusror in the editor? What is the SQL statement?

(0000144) yura_dev (reporter) 2008-02-02 11:30 edited on: 2008-02-02 11:37	> where exactly do you have text cusror in the editor? SQL editor not focused. >What is the SQL statement? Not important. When text cursor in editor sql statement execute normally, but if sql editor not focused, SQL query not execute. It's right?

(0000145) subzero (administrator) 2008-02-02 14:14	ok, thanks. It can be fixed easily. I'll do it later this week.

(0000150) subzero (administrator) 2008-02-04 14:33	can you test it with current revision (386 or later), please? I could not reproduce sql editor without the focus, but I did some changes to place the cursor in the widget by default.

(0000156) yura_dev (reporter) 2008-02-04 18:33	In revision 388 bug still exist. What debugger are you use on windows? Maybe i can create patch.

(0000157) subzero (administrator) 2008-02-04 18:51	I do not use any specialized IDE on windows. Just gvim and mingw compiler. Debugging outputs are done by qDebug(). BTW where is the focus in the sqliteman window just after app started up?

(0000158) yura_dev (reporter) 2008-02-04 19:36 edited on: 2008-02-04 20:00	>BTW where is the focus in the sqliteman window just after app started up? In SQL Editor

(0000160) yura_dev (reporter) 2008-02-05 09:57	Maybe you can reproduce bug, if I describe bug more detailed 1. Run sqliteman 2. Open database 3. Click "New" in SQL editor. Click "Yes" in dialog "New" if need. 4. Open SQL query 5. Run SQL. 6. Open SQL query again 7. Run SQL. Appear message "Undefined SQL query". On step 4-7 you not should give focus SQL editor. I sure this bug exist because SQL editor lost focus. In void SqlEditor::action_Run_SQL_triggered() function query() return empty string in this case.

(0000161) yura_dev (reporter) 2008-02-05 12:10	After debug I found problem in sqleditor.cpp, line 100 if (ui.sqlTextEdit->hasSelectedText()) Maybe hasSelectedText() not should use: http://doc.trolltech.com/4.3/qtextedit-qt3.html#hasSelectedText [^]

(0000162) subzero (administrator) 2008-02-05 13:26	ui.sqlTextEdit is inherited from QsciScitnilla: http://www.riverbankcomputing.com/Docs/QScintilla2/classQsciScintilla.html#4ad54eea41481334d04626732571e01f [^] anyway, it seems fixed in the current revision. Please try fresh SVN.

(0000165) yura_dev (reporter) 2008-02-05 14:03	It works.

(0000167) subzero (administrator) 2008-02-05 14:11	perfect. Thanks for help.

Issue History
Date Modified	Username	Field	Change
2008-02-01 23:46	yura_dev	New Issue
2008-02-02 10:31	subzero	Note Added: 0000143
2008-02-02 11:30	yura_dev	Note Added: 0000144
2008-02-02 11:32	yura_dev	Note Edited: 0000144
2008-02-02 11:37	yura_dev	Note Edited: 0000144
2008-02-02 14:14	subzero	Note Added: 0000145
2008-02-04 14:33	subzero	Note Added: 0000150
2008-02-04 14:33	subzero	Status	new => feedback
2008-02-04 18:33	yura_dev	Note Added: 0000156
2008-02-04 18:51	subzero	Note Added: 0000157
2008-02-04 19:36	yura_dev	Note Added: 0000158
2008-02-04 20:00	yura_dev	Note Edited: 0000158
2008-02-05 09:57	yura_dev	Note Added: 0000160
2008-02-05 12:10	yura_dev	Note Added: 0000161
2008-02-05 13:26	subzero	Note Added: 0000162
2008-02-05 14:03	yura_dev	Note Added: 0000165
2008-02-05 14:11	subzero	Status	feedback => resolved
2008-02-05 14:11	subzero	Fixed in Version	=> 1.1svn
2008-02-05 14:11	subzero	Resolution	open => fixed
2008-02-05 14:11	subzero	Assigned To	=> subzero
2008-02-05 14:11	subzero	Note Added: 0000167
2008-02-11 11:26	subzero	Status	resolved => closed

Relationships